Fix two-frame script delay when respawning#1258
Open
NyakoFox wants to merge 1 commit intoTerryCavanagh:masterfrom
Open
Fix two-frame script delay when respawning#1258NyakoFox wants to merge 1 commit intoTerryCavanagh:masterfrom
NyakoFox wants to merge 1 commit intoTerryCavanagh:masterfrom
Conversation
At some point, there was some "kludge" added to the game which allowed script boxes to immediately get triggered when you enter a room, rather than the update order unfortunately causing scripts to trigger after two frames. For some reason, dying and respawning in a room does not have the same fix, causing really bad inconsistencies for anything that needs precise timing. Despite the initial implementation of the kludge being somewhat careless and breaking levels which relied on timing, this one should not break anything, but in fact fix things, surprisingly.
Daaaav
approved these changes
Dec 9, 2025
Contributor
Daaaav
left a comment
Daaaav
left a comment
There was a problem hiding this comment.
This makes sense and seems to work nicely!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
At some point, there was some "kludge" added to the game which allowed script boxes to immediately get triggered when you enter a room, rather than the update order unfortunately causing scripts to trigger after two frames.
For some reason, dying and respawning in a room does not have the same fix, causing really bad inconsistencies for anything that needs precise timing.
Despite the initial implementation of the kludge being somewhat careless and breaking levels which relied on timing, this one should not break anything, but in fact fix things, surprisingly.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement